Skip to content

Write a custom lint rule to disable use of logrus package #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 10, 2021
Merged

Write a custom lint rule to disable use of logrus package #6357

merged 7 commits into from
Sep 10, 2021

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Aug 4, 2021 •
edited by MarlonGamez
Loading

Shd merge after #6531

As part of @MarlonGamez's proposed solution to wire up logrus debug and info level messages correctly, I am writing a custom lint rule to fail is

  1. logrus is added as a dependency in any files other than allow list.

Currently due to golang/go#19569 and golangci/golangci-lint#1276, there is no way to run private custom linter as part of golangco-lint.

Hence the proposed solution is to run it as a binary in existing hack/golangci-lint.sh.

TODO

  • @MarlonGamez to add allow listed files which can use logrus to create logrus logger instances and configure it.
  • enable the custom logrus logger in hack/golangci-lint.sh by default
Sample output 
➜  skaffold git:(add_lint_rules) CUSTOM_LINTER=true ./hack/golangci-lint.sh
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/constants/constants.go:20:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/context/context.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/util/cmd.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/util/config.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/util/env_template.go:28:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/util/gsutil.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/util/port.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/util/regex.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/util/tar.go:29:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/util/util.go:32:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/util/wrapper_unix.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/cluster/minikube.go:30:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/timeutil/util.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/config/portforward.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/config/util.go:29:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/cmd/skaffold/app/cmd/config/util.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/owner.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/util.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/wait.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/watcher.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/yamltags/tags.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/instrumentation/export.go:35:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/instrumentation/new.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/instrumentation/trace.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/instrumentation/types.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/schema/v2beta16/upgrade.go:20:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/schema/v1beta9/upgrade.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/schema/v1alpha1/upgrade.go:20:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/schema/profiles.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/schema/versions.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/gcp/auth.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/docker/auth.go:33:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/docker/build_args.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/docker/client.go:31:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/docker/docker_init.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/docker/image.go:42:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/docker/image_util.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/docker/parse.go:37:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/docker/remote.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/event/v2/logger.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/warnings/warnings.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/output/color.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/output/output.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/bazel/dependencies.go:30:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/misc/graceful.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/buildpacks/lifecycle.go:33:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/buildpacks/logger.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/custom/script.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/filemon/changes.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/jib/errors.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/jib/gradle.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/jib/init.go:29:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/jib/jib.go:34:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/jib/jvm.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/jib/maven.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/jib/sync.go:30:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/log/stream/stream.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/logger/log.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/hooks/host.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/runner/runcontext/context.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/tag/custom_template.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/tag/git_commit.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/tag/input_digest.go:31:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/build_problems.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/builder_mux.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/result.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/manifest/images.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/manifest/labels.go:20:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/debug/apply_transforms.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/debug/cnb.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/debug/transform.go:61:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/debug/transform_go.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/debug/transform_jvm.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/debug/transform_netcore.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/debug/transform_nodejs.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/debug/transform_python.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/sync/docker.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/sync/sync.go:30:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/label/labels.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/debugging/container_manager.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/portforward/forwarder_manager.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/portforward/kubectl_forwarder.go:31:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/portforward/pod_forwarder.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/portforward/port_forward_integration.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/portforward/resource_forwarder.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/diag/validator/pod.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/resource/deployment.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/status/status_check.go:28:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/kubectl/cli.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/kubectl/kubectl.go:29:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/helm/args.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/helm/deploy.go:36:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/helm/parse.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/helm/util.go:32:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/kustomize/kustomize.go:28:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/initializer/analyze/analyze.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/initializer/deploy/kustomize.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/initializer/config.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/initializer/kompose.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/schema/defaults/defaults.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/tags/paths.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/parser/config.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/cache/cache.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/cache/hash.go:30:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/cache/lookup.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/cache/retrieve.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/cluster/kaniko.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/cluster/logs.go:28:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/cluster/pod.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/cluster/secret.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/gcb/buildpacks.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/gcb/cloud_build.go:31:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/local/local.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/local/prune.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/local/types.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/docker/logger/log.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/docker/deploy.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/docker/port.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/deploy/kpt/kpt.go:31:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/test/structure/structure.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/trigger/fsnotify/trigger.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/trigger/triggers.go:29:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/runner/build.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/runner/builder.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/runner/listen.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/runner/timings.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/server/server.go:29:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/runner/v1/deploy.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/runner/v1/dev.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/runner/v1/new.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/schema/validation/validation.go:30:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/survey/survey.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/update/update.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/cmd/skaffold/app/cmd/cmd.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/cmd/skaffold/app/cmd/dev.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/cmd/skaffold/app/cmd/flags.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/cmd/skaffold/app/cmd/runner.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/cmd/skaffold/app/skaffold.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/cmd/skaffold/skaffold.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/hack/versions/pkg/diff/godiff.go:28:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/hack/versions/pkg/schema/check.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/hack/versions/pkg/schema/version.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/hack/versions/cmd/latest/version.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/hack/versions/cmd/latest_released/version.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/hack/versions/cmd/new/version.go:29:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/hack/versions/cmd/schema_check/check.go:20:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/hack/versions/cmd/update_comments/main.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/integration/binpack/binpack.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/integration/util.go:31:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/integration/skaffold/helper.go:30:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/render/generate/generate.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/render/renderer/renderer.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/integration/build_dependencies_test.go:25:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/integration/build_test.go:28:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/integration/dev_dependencies_test.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/integration/dev_test.go:31:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/integration/port_forward_test.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/integration/binpack/binpack_test.go:23:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/build/cluster/logs_test.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/event/v2/logger_test.go:22:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/kubernetes/context/context_test.go:24:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/runner/timings_test.go:26:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.
/Users/tejaldesai/workspace/skaffold/pkg/skaffold/runner/timings_test.go:27:2: Dont use github.com/sirupsen/logrus package, use output.Log instead.

@tejal29 tejal29 requested a review from MarlonGamez August 4, 2021 01:17
@tejal29 tejal29 requested a review from a team as a code owner August 4, 2021 01:17
@google-cla google-cla bot added the cla: yes label Aug 4, 2021
@codecov
Copy link

codecov bot commented Aug 4, 2021 •
edited
Loading

Codecov Report

Merging #6357 (6e1ab72) into main (290280e) will decrease coverage by 0.06%.
The diff coverage is 45.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6357      +/-   ##
==========================================
- Coverage   70.48%   70.42%   -0.07%     
==========================================
  Files         515      517       +2     
  Lines       23150    23265     +115     
==========================================
+ Hits        16317    16384      +67     
- Misses       5776     5822      +46     
- Partials     1057     1059       +2
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/flags.go 90.81% <ø> (ø)
cmd/skaffold/skaffold.go 0.00% <ø> (ø)
pkg/skaffold/build/buildpacks/logger.go 0.00% <ø> (ø)
pkg/skaffold/build/cluster/logs.go 0.00% <ø> (-16.67%) ⬇️
pkg/skaffold/config/options.go 100.00% <ø> (ø)
pkg/skaffold/docker/logger/log.go 22.64% <0.00%> (-0.44%) ⬇️
pkg/skaffold/kubectl/exec.go 100.00% <ø> (ø)
pkg/skaffold/kubernetes/debugging/transform.go 84.44% <0.00%> (ø)
...affold/kubernetes/portforward/kubectl_forwarder.go 73.33% <0.00%> (ø)
pkg/skaffold/schema/latest/v1/config.go 62.16% <ø> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc896b8...6e1ab72. Read the comment docs.

@tejal29 tejal29 force-pushed the add_lint_rules branch 2 times, most recently from 53d6a2f to 7e6d540 Compare August 4, 2021 02:24
briandealwis
briandealwis approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rm -rf hack/tools/vendor too

@tejal29 tejal29 force-pushed the add_lint_rules branch 2 times, most recently from 9abb1f6 to d56ce77 Compare August 27, 2021 02:20
@tejal29 tejal29 merged commit f8e5474 into GoogleContainerTools:main Sep 10, 2021
@tejal29 tejal29 deleted the add_lint_rules branch November 9, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandealwis briandealwis briandealwis approved these changes

@MarlonGamez MarlonGamez Awaiting requested review from MarlonGamez

Assignees
No one assigned
Labels
cla: yes size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejal29 @briandealwis @MarlonGamez